OTTAA-Project / ottaa_project_flutter

Join us to create the first predictive augmentative communication platform for speech-impaired children!
https://ottaa-project.github.io/
GNU General Public License v3.0
10 stars 4 forks source link

Fix/default language #249

Closed emirchus closed 1 year ago

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [2655369](https://dashboard.gitguardian.com/incidents/2655369?occurrence=89903879) | Google API Key | a398d7c352d5850944307774e55e8765299bfb12 | ios/Runner/GoogleService-Info.plist | [View secret](https://github.com/OTTAA-Project/ottaa_project_flutter/commit/a398d7c352d5850944307774e55e8765299bfb12#diff-3644715e6db0d8eb16f43d29561af921c151dd5c22ee7d68ae3e0f32cce351afR12) | | [2655369](https://dashboard.gitguardian.com/incidents/2655369?occurrence=90412058) | Google API Key | 20cdf00e65f320ff1c30ccf7aa9f3ab2e4ca3869 | ios/Runner/GoogleService-Info.plist | [View secret](https://github.com/OTTAA-Project/ottaa_project_flutter/commit/20cdf00e65f320ff1c30ccf7aa9f3ab2e4ca3869#diff-3644715e6db0d8eb16f43d29561af921c151dd5c22ee7d68ae3e0f32cce351afR12) | | [2655369](https://dashboard.gitguardian.com/incidents/2655369?occurrence=90459355) | Google API Key | 632bac70eb9cf78810a9b2c65300a913aeedc9d3 | ios/Runner/GoogleService-Info.plist | [View secret](https://github.com/OTTAA-Project/ottaa_project_flutter/commit/632bac70eb9cf78810a9b2c65300a913aeedc9d3#diff-3644715e6db0d8eb16f43d29561af921c151dd5c22ee7d68ae3e0f32cce351afR12) | | [2655369](https://dashboard.gitguardian.com/incidents/2655369?occurrence=90466362) | Google API Key | fb5918df4b2e3d54c3ed8b88818b1ff8bfead961 | ios/Runner/GoogleService-Info.plist | [View secret](https://github.com/OTTAA-Project/ottaa_project_flutter/commit/fb5918df4b2e3d54c3ed8b88818b1ff8bfead961#diff-3644715e6db0d8eb16f43d29561af921c151dd5c22ee7d68ae3e0f32cce351afL12) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/googleaiza#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

hectoritr commented 1 year ago

@asimjawad can you review this PR looking for exposed keys, I know that there are some that need to be public for Firebase web. But I think there are others that shouldn't. Please comment here with your opinions.

asimjawad commented 1 year ago

We need to keep these files out of the public repos:

Other than that, I don't think we need to keep some more files hidden, If there were some They should be already in the .gitignore file

hectoritr commented 1 year ago

@emirchus PR requested to merge to master