search

OUGC-Network / OUGC-Awards

Adds a powerful awards system to you community.
https://ougc.network
GNU General Public License v3.0
8 stars 7 forks source link

Online time for achievements is broken #81

Closed Sama34 closed 9 months ago

Sama34 commented 9 months ago

Describe the bug Time online for award achievements is broken, as the logic makes use of the current time, but this makes no sense.

https://github.com/OUGC-Network/OUGC-Awards/blob/master/Upload/inc/tasks/ougc_awards.php#L87-L110

Expected behavior Time online shouldn't be subtracted from the current time stamp for comparison.

Additional context Should be similar to the core online time promotion logic : https://github.com/mybb/mybb/blob/feature/inc/tasks/promotions.php

Sama34 commented 9 months ago

Fixed in 1.8.33