OUPMATH / OxfrodMaths_Prod

0 stars 0 forks source link

School admin login-Class not changing when notification is sent to different classes #51

Closed madhumitadey closed 8 years ago

madhumitadey commented 8 years ago
  1. Login using School admin credentials.
  2. Go to create notification.
  3. Create notification for any class except 3. Here notification has been created for Class 4.

image

Problem encountered: Under the notification history, the class displayed is always Class 3 (note that the notification was created for Grade 4). On editing/viewing the notification, the wrong class is displayed. image

pankaj44 commented 8 years ago

Hi Madhumita, I have checked the above defect in UAT. It is working fine. Please find the screen-shot for your reference

image

image

Could you please test it in different school and let me know the output.

madhumitadey commented 8 years ago

The issues has been resolved when notification is sent to students.

image

image

I have tested it on the production site. Should I try this in UAT environment?

pankaj44 commented 8 years ago

Hi Madhumita, Could you please check it for different school.

madhumitadey commented 8 years ago

Okay.

pankaj44 commented 8 years ago

Please check in UAT and let me know.

madhumitadey commented 8 years ago

This is not working on UAT as well. I tried sending a notification to a Grade 4 teacher. image

image

pankaj44 commented 8 years ago

Hi Madhumita, Could you please share the school admin credentials from UAT.I will check and let you know.

madhumitadey commented 8 years ago

Hi Pankaj, The credentials are:

Username: S3_5 Password: OUPMath@363

However, I just tried checking it for a new school on UAT, it is working fine there.

pankaj44 commented 8 years ago

Hi Madhumita, Above credential is not working. Could you please re-check and let me know the correct credential. I am checking it in UAT.

madhumitadey commented 8 years ago

I have reset the password. Please try with the following credentials. Username: S3_5 Password: OUPMath@568

pankaj44 commented 8 years ago

Hi Madhumita, I have investigated the issue and found that single teacher is associate with multiple class and section. Hence if you create a notification for class 4 in notification history you are able to see the class 3.

Please let me know if you have any queries.

madhumitadey commented 8 years ago

@mayank2k2 Please check and suggest.

mayank2k2 commented 8 years ago

Pankaj, this is wrong implementation. if we create notification for class 4& section D, it should be for crated for same class 4& section D. how it is showing different class & section.

pankaj44 commented 8 years ago

Hi Mayank, Suppose a teacher is assign to a class 4 and Section D also he is assign for a class 3 and section C. If you are creating a notification for class 4 and section D then that will be applicable for class 3 and section C also because same teacher is associate with both the class and section.

technical side. We are not mapping a notification to class or section. Currently the implementation is like If you create a notification for a particular teacher then it will go for all class and sections.

mayank2k2 commented 8 years ago

we need to fix the issue as expected

pankaj44 commented 8 years ago

Hi Mayank/Madhumita, I have done the changes and deployed it in UAT. Could you please check and let me know your feedback.

Example:- If teacher is associate with more than one class and section then only those class section will be visible in notification history those you are creating.

madhumitadey commented 8 years ago

Looks good to me. Kindly notify when the changes will be made in production. Will check and close the issue.

pankaj44 commented 8 years ago

Production deployment has been completed. Could you please check it and close the defect.

mayank2k2 commented 8 years ago

attached the document shared by pankaj Notification.docx

mayank2k2 commented 8 years ago

wrongly closed,

mayank2k2 commented 8 years ago

Please check in production

madhumitadey commented 8 years ago

Working fine on production.