search

OUPMATH / OxfrodMaths_Prod

0 stars 0 forks source link

Cookie inplementation is not correct #53

Closed mayank2k2 closed 8 years ago

mayank2k2 commented 8 years ago

we observe that cookie implementation is not correct, the name of the cookie is firsttime_cookie which should be oup-cookie as a standard. also please find attached document for verify correct implementation. International Production Deployment instructions 2.1.docx

pankaj44 commented 8 years ago

I am looking into it.

pankaj44 commented 8 years ago

Hi Mayan, I have deployed the changes in UAT. Please clear the cash and cookies and check it.

mayank2k2 commented 8 years ago

can you name the files where you have made the changes?

pankaj44 commented 8 years ago

This file is Login.cshtml

pankaj44 commented 8 years ago

Hi Mayank, I have done the changes and deployed in QA. Could you please check and let me know.

mayank2k2 commented 8 years ago

can you check why i am getting style issue image

pankaj44 commented 8 years ago

Hi Mayank, I have done the modification as per our conversation and deployed it in QA. Could you please check and let me know.

mayank2k2 commented 8 years ago

The message and its height is fine but height of blue bar is more, please compare with production. [cid:image001.png@01D20387.DB98FAF0]

In production

[cid:image002.png@01D20388.0F2E64E0] Thanks, Mayank Mishra

From: pankaj44 [mailto:notifications@github.com] Sent: Wednesday, August 31, 2016 12:57 PM To: OUPMATH/OxfrodMaths_Prod OxfrodMaths_Prod@noreply.github.com Cc: MISHRA, Mayank Mayank.Mishra@oup.com; Assign assign@noreply.github.com Subject: Re: [OUPMATH/OxfrodMaths_Prod] Cookie inplementation is not correct (#53)

Hi Mayank, I have done the modification as per our conversation and deployed it in QA. Could you please check and let me know.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/OUPMATH/OxfrodMaths_Prod/issues/53#issuecomment-243681069, or mute the threadhttps://github.com/notifications/unsubscribe-auth/APfLWlsaS5gWeGJ18jfjZK1lLIzO3SUrks5qlSy2gaJpZM4Jpkbz.

pankaj44 commented 8 years ago

I have done the changes in QA. Could you please check and let me know your feedback.

pankaj44 commented 8 years ago

Production deployment has been completed. Please check it and close the defect.

mayank2k2 commented 8 years ago

working in production, so closing the issue