OV2 / RapidCRC-Unicode

Windows tool to quickly create and verify hash checksums
https://www.ov2.eu/programs/rapidcrc-unicode
GNU General Public License v2.0
300 stars 29 forks source link

When creating hashes, "Info" column should not be displaying irrelevant messages. #50

Open DroidSparks opened 7 years ago

DroidSparks commented 7 years ago

Basically, when first creating hashes, "Info" column should not be displaying "No hash found" or "File corrupt" when 'Hashtype from filename' is unchecked.

It should be displaying "Creating new hash" or whatever.

"23/23 done, 16x file corrupt, 7x no hash found" makes no sense with that option off.

mmortal03 commented 4 months ago

I'm surprised this hasn't been fixed. As a new user of the program this was confusing, as it made no sense that it had found files to be corrupt before it had ever been used to create hashes in the first place. Also, the delimiters, the underscore in particular, (which can be removed, of course), has it detecting parts of filenames that aren't actually hashes. It'd be great if detecting hashes in the filenames could just be turned off, rather than removing particular delimiters.

Edit: Delimiters rather than strings of numbers.

OV2 commented 4 months ago

The 'Hashtype from filename' setting enables determining the hash type from the filename, for example to detect that "sha256sum.txt" is a file containing sha256 sums.

Detecting hashes from filenames can be deactivated by removing all delimiters. Why do you want to keep them in if you want to disable this feature?

mmortal03 commented 4 months ago

Thanks, that definitely makes sense programmatically. I think part of it is the wording of "Allow the following characters as", which, to me, doesn't come across as explicit enough. I understand now that having anything present in that textbox will always look for CRCs in the filenames.
Maybe adding a checkbox next to "Allow the following characters as", would make it more intuitive? When the checkbox was unchecked it would also gray out the delimiter textbox. That would serve the further purpose of retaining whatever delimiters you've entered into the textbox if you're wanting to enable/disable the feature without remembering or having to re-enter which delimiters you previously used.