OV2 / RapidCRC-Unicode

Windows tool to quickly create and verify hash checksums
https://www.ov2.eu/programs/rapidcrc-unicode
GNU General Public License v2.0
295 stars 30 forks source link

blake3 checksum files are incompatible with reference implementation #93

Closed Ost3rbaer closed 2 years ago

Ost3rbaer commented 2 years ago

The reference implementation from https://github.com/BLAKE3-team/BLAKE3 can not verify blake3 hash files generated by RapidCRC for two reasons

One could consider this as a flaw of the reference implementation, but non-binary files are meaningless in the UNIX world.

When checking "create UNIX style hash files" under options, the output uses LF line endings (good) but file names are still preceeded by asteriks (bad).

RapidCRC should generate compatible files when the compatibility option is selected.

OV2 commented 2 years ago

This was implemented before the official b3sum had any check support, and I simply used the same format as md5/shaX. I've pushed a commit to always write .blake3 files without a *.

tERyceNzAchE commented 2 years ago

I agree with @Ost3rbaer that this change should only be when the option is checked, and the current behavior maintained otherwise. The currently generated files are compatible with HashCheck, which is the other very popular Windows program for generating hashes.

OV2 commented 2 years ago

HashCheck can also read files without a , so it should be ok to create all .blake3 files without the in the future.