OVOSHatchery / ovos-PHAL-plugin-sj201-leds

plugin for mark2 DEV KIT leds (wont work in production mk2)
Apache License 2.0
1 stars 0 forks source link

Naming issue #3

Open denics opened 2 months ago

denics commented 2 months ago

we should find a consistent way to address the naming, i.e. we already have : ovos-PHAL-plugin-mk2-fan-control which repo is called https://github.com/OpenVoiceOS/ovos-PHAL-plugin-mk2-v6-fan-control

and this is: ovos-PHAL-plugin-sj201-leds in https://github.com/OVOSHatchery/ovos-PHAL-plugin-sj201-leds

and both are restricted to the devkit

JarbasAl commented 2 months ago

https://github.com/OVOSHatchery/ovos-PHAL-plugin-sj201-leds/pull/2 this one might support the production mk2

builderjer commented 2 months ago

I still haven't figured out how to control the production unit without root privileges. After that, they will be combined into a single plugin

builderjer commented 1 month ago

Also, the sj201 can be attached to another pi and it would no longer be a Mark2, but you would still want the plugin for the LED's.

The fan may be connected differently than the mk2