Error in debug flow - Githubissues

OVOSHatchery / ovos-skill-node-red

mycroft skills with node red

Apache License 2.0

30 stars 12 forks source link

Error in debug flow #8

Open Ostrochibi opened 4 years ago

Ostrochibi commented 4 years ago

Hi,

Nice job for this skill, very usefull. Thank you

When you trigger the converse sequence in debug flow, mycroft says skill.error, is that normal?

I try to understant how converse works but you have made node example. Can you provide an example of a simple conversation pls, that would be very usefull.

So far i understand, all solution i found seems to huge to be correct. It's seems like you have a the node "filter" in the flow "bus" and you use a flow variable but the two possible way you add to this node point at the same place. I am lost :)

Thank you again.

JarbasAl commented 4 years ago

in this skill context, converse just means "before mycroft intents"

for example the included weather intent has a collision with mycroft weather skill, with converse on node red will be executed, with converse off mycroft's skill will be executed

skill.error is not normal, i will try to replicate on my side, if you could provide skill logs that would be great

JarbasAl commented 4 years ago

the flow merges converse/fallback into a single parsing step, you could however have different intents for each stage if you want to split both of those

in general this will not be necessary, i decided it was best to have a single place to handle intents and a simple mechanism to control converse/fallback

Ostrochibi commented 4 years ago

Ok, i gonna give you an example to add to your repo if you want when i finish about how i map the converse things. Can you tell me more about the skill.error provide by mycroft when you try the debug flow pls?

keiner99 commented 3 years ago

I changed to this skill, works like a charm and needs fewer dependencies: https://github.com/erikkt/myqtt

JarbasAl commented 3 years ago

@keiner99 please dont advertise other skills in every issue... I don't mind you linking to other skills, but i mind spamming different issues with the same thing over and over.

that needs fewer dependencies because it does totally different things

a quick summary:

my skill is not about lang support, home assistant, or mqtt
my skill is quite old and needs a big version bump, as you can see from issues it does not work in latest mycroft (the install doesn't, the skill itself does if you handle that manually)
my skill uses the hivemind and isolates the messagebus, with the one you are advertising you are vulnerable , https://github.com/Nhoya/MycroftAI-RCE
DO NOT EXPOSE YOUR MESSAGEBUS
DO NOT EXPOSE YOUR MESSAGEBUS SPECIALLY WITHOUT AUTHENTICATION

note: the skill you linked does not provide a license either

I will try to find some time to give a cleanup to my skill