search

OVOSHatchery / skill-ovos-dismissal

MIT License
6 stars 10 forks source link

add "cancel" as dismissal word #13

Closed Mic92 closed 2 years ago

Mic92 commented 2 years ago

Upstream decided not to include this in their stop action:

https://github.com/MycroftAI/skill-stop/pull/47#issuecomment-1060089552

Hence it's save for this intent.

ChanceNCounter commented 2 years ago

Will merge, not currently at a computer. Good thought.

ChanceNCounter commented 2 years ago

On reflection, this seems likely to clash with intents that cancel long-lived jobs, like timers, alarms, or appointments on a calendar.