search

OVOSHatchery / skill-ovos-dismissal

MIT License
6 stars 10 forks source link

Add default setting value to ensure tests pass #6

Closed krisgesling closed 4 years ago

krisgesling commented 4 years ago

Hey Chance, just caught this while testing for the 20.08 release. Not critical but would avoid it getting flagged in the future.

When running in a test environment, the Skill may not have received its settings when the first test runs. In this instance verbal_feedback_endabled will be None and no dialog will be spoken causing the test to fail.

This adds the existing default from settingsmeta.json into the check.

ChanceNCounter commented 4 years ago

Good catch. Thanks, Gez!