Open SahilDhillon21 opened 1 day ago
@SahilDhillon21 How do you plan to approach this? If there is no mention of issue number, how can we close a particular issue?
Can we enforce linking the issue to the PR?
/assign
Hello @apoorvapendse! You've been assigned to OWASP-BLT/BLT. You have 24 hours to complete a pull request. To place a bid and potentially earn some BCH, type /bid [amount in BCH] [BCH address].
Yes we can enforce the linking of issue and pr as well as maybe leave a note or close the issue directly if it has a merged PR and maybe no other activity for let's say 3 days
@apoorvapendse apart from enforcing we can also use simple comments and I wasn't exactly sure of what all to add, but I created some experimental changes for which I was planning to raise a PR. Maybe we will be able to combine different ideas
Sounds good 👍
Yes we can enforce the linking of issue and pr as well as maybe leave a note or close the issue directly if it has a merged PR and maybe no other activity for let's say 3 days
That might be a bit risky Some PRs might partially address a given issue as a side effect. Which might close them even when it wasn't intended.
I've created a PR for this, would like to discuss your thoughts on the same @SahilDhillon21
⏰ This issue has been automatically unassigned due to 24 hours of inactivity. The issue is now available for anyone to work on again.
Sometimes users forget to close the related issue after merging a PR. I suggest adding a GitHub Action to automatically close the issue upon PR merge. If this approach seems useful, I’d be glad to take on the implementation.