OWASP-BLT / BLT

OWASP BLT is tool with the purpose of making the web a safer place. We have many facets to the project.
https://blt.owasp.org
GNU Affero General Public License v3.0
139 stars 144 forks source link

Add GitHub Action to Automatically Close Issues When PR is Merged #3032

Open SahilDhillon21 opened 1 day ago

SahilDhillon21 commented 1 day ago

Sometimes users forget to close the related issue after merging a PR. I suggest adding a GitHub Action to automatically close the issue upon PR merge. If this approach seems useful, I’d be glad to take on the implementation.

apoorvapendse commented 1 day ago

@SahilDhillon21 How do you plan to approach this? If there is no mention of issue number, how can we close a particular issue?

DonnieBLT commented 1 day ago

Can we enforce linking the issue to the PR?

apoorvapendse commented 1 day ago

/assign

github-actions[bot] commented 1 day ago

Hello @apoorvapendse! You've been assigned to OWASP-BLT/BLT. You have 24 hours to complete a pull request. To place a bid and potentially earn some BCH, type /bid [amount in BCH] [BCH address].

SahilDhillon21 commented 1 day ago

Yes we can enforce the linking of issue and pr as well as maybe leave a note or close the issue directly if it has a merged PR and maybe no other activity for let's say 3 days

SahilDhillon21 commented 1 day ago

@apoorvapendse apart from enforcing we can also use simple comments and I wasn't exactly sure of what all to add, but I created some experimental changes for which I was planning to raise a PR. Maybe we will be able to combine different ideas

apoorvapendse commented 1 day ago

Sounds good 👍

apoorvapendse commented 1 day ago

Yes we can enforce the linking of issue and pr as well as maybe leave a note or close the issue directly if it has a merged PR and maybe no other activity for let's say 3 days

That might be a bit risky Some PRs might partially address a given issue as a side effect. Which might close them even when it wasn't intended.

apoorvapendse commented 1 day ago

I've created a PR for this, would like to discuss your thoughts on the same @SahilDhillon21

github-actions[bot] commented 4 hours ago

⏰ This issue has been automatically unassigned due to 24 hours of inactivity. The issue is now available for anyone to work on again.