search

OWASP-Benchmark / BenchmarkUtils

OWASP Benchmark Project Utilities - Provides scorecard generation and crawling tools for Benchmark style test suites.
https://owasp.org/www-project-benchmark/
GNU General Public License v3.0
16 stars 50 forks source link

use maven cache #14

Closed darkspirit510 closed 2 years ago

darkspirit510 commented 3 years ago

I prefer using cache for dependencies... 🙈

davewichers commented 3 years ago

What does 'cache: maven' do? And should we make similar changes to other Benchmark Java projects?

darkspirit510 commented 3 years ago

In short: Setup cache in background so maven does not have to download all the dependencies on each action run.

The action has a built-in functionality for caching and restoring dependencies. It uses actions/cache under
hood for caching dependencies but requires less configuration settings. Supported package managers are
gradle and maven. The cache input is optional, and caching is turned off by default.

Source: https://github.com/actions/setup-java

davewichers commented 2 years ago

Any clue how I test this myself to make sure it works/doesn't break anything before I merge this change in?

darkspirit510 commented 2 years ago

I guess for security reasons GitHub actions don't run on pull requests. You can see the the cache in action in my branch:

https://github.com/darkspirit510/BenchmarkUtils/runs/5034543172?check_suite_focus=true

(Expand Set up JDK 1.8)