search

OWASP-Benchmark / BenchmarkUtils

OWASP Benchmark Project Utilities - Provides scorecard generation and crawling tools for Benchmark style test suites.
https://owasp.org/www-project-benchmark/
GNU General Public License v3.0
13 stars 48 forks source link

fix HCL AppScan Source reader #39

Closed mattmurp closed 1 year ago

darkspirit510 commented 1 year ago

Hi Matt(murp), thank you for the PR. The code you submitted looks good, but I can't tell, if it works. Can you please either add a small test class for the AppScanSourceReader or, even better, send me a (real) result file github@darkspirit510.de? I can offer to write a test with a reduced/censored file and review the change with it. Sascha

mattmurp commented 1 year ago

Thanks Sascha. I sent you a sample xml file. Let me know if there's anything else you need.

darkspirit510 commented 1 year ago

You've got mail 😉 one additional thing, I just noticed (can't comment it via GitHub): The tool is named HCL, but in the code it says IBM. I guess this is not right (anymore). Can you check this?

davewichers commented 1 year ago

@mattmurp - Can you address @darkspirit510's comments?

mattmurp commented 1 year ago

Sorry for the delay. I just pushed the requested updates.

davewichers commented 1 year ago

@darkspirit510 - You OK with this now, approve the merge?

darkspirit510 commented 1 year ago

@davewichers yes! 👍

mattmurp commented 1 year ago

Hi @davewichers and @darkspirit510 can this be merged now? Thanks.