Closed 0xgoto closed 1 year ago
What's the status on this? Are there more comments from @darkspirit510 to be addressed? If not, @darkspirit510, do you think this is ready for merge?
I have resolved everything that @darkspirit510 stated.
@darkspirit510 - can you review his last commit and confirm everything is good from your perspective before I review (and hopefully merge)?
@davewichers looks good to me 😊
Thank you for this PR. I wrote some comments to the files. Can you somehow reduce the size of the test file?