search

OWASP-Benchmark / BenchmarkUtils

OWASP Benchmark Project Utilities - Provides scorecard generation and crawling tools for Benchmark style test suites.
https://owasp.org/www-project-benchmark/
GNU General Public License v3.0
13 stars 48 forks source link

Upgrade Acunetix plugin #41

Closed tree-chtsec closed 1 year ago

davewichers commented 1 year ago

@darkspirit510 - Can you review these changes? Maybe get a test file from @tree-chtsec so we can build a unit test for this? And Ideally support the old and new format at the same time.

tree-chtsec commented 1 year ago

Acuentix Version: 15.3.230123162 For the test file, please check the XML result of https://demo.testfire.net from here

The main difference between old and new is that Old: <CWE id="79"><![CDATA[CWE-79]]></CWE> New: <CWEList><CWE id="79"><![CDATA[CWE-79]]></CWE></CWEList>

I have made the parser compatible with old & new version of legacy XML.

tree-chtsec commented 1 year ago

I'll add test case to plugin/src/test/resources/testfiles/ folder.

tree-chtsec commented 1 year ago

I updated the AcunetixReaderTest.java and passed Junit Test with mvn test result below.

image
davewichers commented 1 year ago

@darkspirit510 - you good with this merge request now?

darkspirit510 commented 1 year ago

@davewichers yes! 👍

tree-chtsec commented 1 year ago

Hello, can this PR get merged by anyone?