search

OWASP-Benchmark / BenchmarkUtils

OWASP Benchmark Project Utilities - Provides scorecard generation and crawling tools for Benchmark style test suites.
https://owasp.org/www-project-benchmark/
GNU General Public License v3.0
13 stars 48 forks source link

Refactor testsuiteresults #56

Closed darkspirit510 closed 5 months ago

darkspirit510 commented 8 months ago

Hi Dave,

Currently, most classes in BenchmarkUtils contain domain logic, but also report/transformation code. I want to split this to seperate classes, but this will need some preparations and several PRs. I hope the other PRs will be smaller :-)

this PR

Tests are green, but I can't install the plugin to test it with BenchmarkJava. Will remove the WIP flag as soon as this works. Feedback already appreciated.

davewichers commented 5 months ago

@darkspirit510 - Hey - was I supposed to review this MR? Why did you close it?

darkspirit510 commented 5 months ago

@davewichers I wasn't sure if you'd accept this because it has been open quite some time. I could reopen it and resolve conflicts.

davewichers commented 5 months ago

@darkspirit510 - if you think this is an improvement and want to merge it in, either reopen and resolve conflicts, or create a new branch. Sorry I didn't notice you wanted me to review it. I certainly don't want to discard useful work on your part.