OWASP-Benchmark / BenchmarkUtils

OWASP Benchmark Project Utilities - Provides scorecard generation and crawling tools for Benchmark style test suites.
https://owasp.org/www-project-benchmark/
GNU General Public License v3.0
13 stars 48 forks source link

Checkmarx results parser - Normalize paths #71

Closed cx-rafaelc closed 1 month ago

cx-rafaelc commented 1 month ago

Normalize SAST results file path in order to compute OWASP scorecard on Windows or Linux base scans .

davewichers commented 1 month ago

@darkspirit510 - can you look at this change? Are there other parsers we should make a similar change to in order to platform independent, like this change does? This change looks fine to me.

davewichers commented 1 month ago

@darkspirit510 - I merged this, but would still like you to look if a similar change should be applied to other parsers.

darkspirit510 commented 1 month ago

org.owasp.benchmarkutils.score.parsers.Reader#extractFilename should already handle Linux and Windows path to extract filename. You could check if this works and if not, fix the method so all readers beneftit from it 🥹