Closed This-is-Neo closed 6 days ago
Hi @This-is-Neo, The PR needs some changes before becoming ready for merge. Please kindly review my comments.
Remember that you can render the site locally using docker. To add the Persian translation to the languages selector you should do the following change:
diff --git a/editions/2023/mkdocs.yml b/editions/2023/mkdocs.yml index e4f73e3..505c4d2 100644 --- a/editions/2023/mkdocs.yml +++ b/editions/2023/mkdocs.yml @@ -9,3 +9,5 @@ extra: lang: en - name: Français lang: fr + - name: Persian + lang: fa
Also note that we are no longer providing the
ODT
/Cheers, Paulo A. Silva
Hi @PauloASilva , I wanted to let you know that the updates and revisions you requested in this part have been completed and committed. Please feel free to review them, and let me know if any further adjustments are needed.
Also, is there anything else I should consider adding or refining in the Mkdocs.yml file, particularly related to content structure or editing configurations? For example, should I include something like this for additional markdown support:
markdown_extensions:
- footnotes
Best regards,
Hi @This-is-Neo, Carefully review my comments: some requested changes apply to all translation sources.
Please compare you sources with the original ones in terms of structure e.g. headings, unnecessary
---
, use of markup instead of markdown when not required, ...Take your time to carefully review the translation source making sure it follows the original
EN
source as much as possible. Keep in mind that reviews like this one require a lot of time and effort from all of us.Cheers, Paulo A. Silva
Hi @This-is-Neo, Carefully review my comments: some requested changes apply to all translation sources.
Please compare you sources with the original ones in terms of structure e.g. headings, unnecessary
---
, use of markup instead of markdown when not required, ...Take your time to carefully review the translation source making sure it follows the original
EN
source as much as possible. Keep in mind that reviews like this one require a lot of time and effort from all of us.Cheers, Paulo A. Silva
Hi @PauloASilva ,
I have completed the revisions as requested. Below is a summary of the updates I made:
These changes should now make the document fully aligned with the original English source and address all of your previous comments. Please feel free to review and let me know if any further adjustments are needed.
Best regards,
These changes should now make the document fully aligned with the original English source and address all of your previous comments. Please feel free to review and let me know if any further adjustments are needed.
Unfortunately, they don't: build process is broken I guess due to editions/2023/mkdocs.yml
changes.
I may take a while to put this together so that it can be merged.
Cheers, Paulo A. Silva
Add Persian (fa) edition for API Security 2023