Closed b34c0n5 closed 2 months ago
@jmanico and @szh how it happened that it was merged while tests were failing for this PR? Now all builds are failing. We need to update but we need to do this right. See the error: https://github.com/OWASP/CheatSheetSeries/actions/runs/8949746883/job/24584392999
The conflict is caused by: The user requested Jinja2==3.1.2 The user requested Jinja2==3.1.3
This PR is lowering Jinja2 version and because if that it is declared 2 times
@jmanico this is why we need 2 reviewers to approve before merging and tests must pass
Can we make all of the GH actions required for merging? Right now for some reason they're not.
I do apologise, I issued a revert request as well.
My apologies I am with you when it comes to review. I typically only merge when all tests succeed but will be more careful.
Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.
Please make sure that for your contribution:
[TEXT](URL)
If your PR is related to an issue, please finish your PR text with the following line:
This PR covers issue #.
Thank you again for your contribution :smiley: