OWASP / CheatSheetSeries

The OWASP Cheat Sheet Series was created to provide a concise collection of high value information on specific application security topics.
https://cheatsheetseries.owasp.org
Creative Commons Attribution Share Alike 4.0 International
27.08k stars 3.79k forks source link

Idna/Jinja update to reduce vulns #1390

Closed b34c0n5 closed 2 months ago

b34c0n5 commented 2 months ago

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

:triangular_flag_on_post: If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

If your PR is related to an issue, please finish your PR text with the following line:

This PR covers issue #.

Thank you again for your contribution :smiley:

mackowski commented 1 month ago

@jmanico and @szh how it happened that it was merged while tests were failing for this PR? Now all builds are failing. We need to update but we need to do this right. See the error: https://github.com/OWASP/CheatSheetSeries/actions/runs/8949746883/job/24584392999

The conflict is caused by: The user requested Jinja2==3.1.2 The user requested Jinja2==3.1.3

This PR is lowering Jinja2 version and because if that it is declared 2 times Screenshot 2024-05-09 at 15 05 29

@jmanico this is why we need 2 reviewers to approve before merging and tests must pass

szh commented 1 month ago

Can we make all of the GH actions required for merging? Right now for some reason they're not.

b34c0n5 commented 1 month ago

I do apologise, I issued a revert request as well.

jmanico commented 1 month ago

My apologies I am with you when it comes to review. I typically only merge when all tests succeed but will be more careful.