OWASP / CheatSheetSeries

The OWASP Cheat Sheet Series was created to provide a concise collection of high value information on specific application security topics.
https://cheatsheetseries.owasp.org
Creative Commons Attribution Share Alike 4.0 International
27.06k stars 3.79k forks source link

Update NPM_Security_Cheat_Sheet.md #1421

Closed wittjoe1 closed 3 weeks ago

wittjoe1 commented 3 weeks ago

Responsibly disclosure security vulnerabilities:

security vulnerabilities are a potentially serious threat for users who cannot protect themselves

Thank you for submitting a Pull Request (PR) to the Cheat Sheet Series.

:triangular_flag_on_post: If your PR is related to grammar/typo mistakes, please double-check the file for other mistakes in order to fix all the issues in the current cheat sheet.

Please make sure that for your contribution:

If your PR is related to an issue, please finish your PR text with the following line:

none

Thank you again for your contribution :smiley:

szh commented 3 weeks ago

@jmanico can you please explain why you chose to merge this without two reviewers?

jmanico commented 3 weeks ago

It was just one line of text modification that was very minor. I’m happy to hold off on even these small changes in the future though!

szh commented 3 weeks ago

@jmanico I understand it's minor, but I had an unresolved comment on it already. I would appreciate if you could at least address any questions from other reviewers before merging. The proposed change also contains a spelling issue (publicised vs publicized - we usually standardize on US) but I was hoping to address the question of need before going into making spelling nits.

jmanico commented 3 weeks ago

Gotchya. I’ll hold back on merging until we get the needed reviews moving forward.

szh commented 3 weeks ago

Thanks @jmanico, I appreciate it 👍