search

OWASP / Go-SCP

Golang Secure Coding Practices guide
https://owasp.org/www-project-go-secure-coding-practices-guide/
Creative Commons Attribution Share Alike 4.0 International
4.83k stars 369 forks source link

Error validation-and-storage #100

Closed dreddsa5dies closed 4 months ago

dreddsa5dies commented 5 months ago

Hi. There are code inserts with the bcrypt library in the text (link). However, the code itself is incorrect. Here is an example with goplay: https://play.golang.com/p/kqXCPZ7ifCQ Suggest the right changes?

PauloASilva commented 4 months ago

You mean CompareHashAndPassword() arguments in the code sample are in the wrong order, is that it?

I'll be glad to approve your PR to fix this.

Cheers, Paulo A. Silva

dreddsa5dies commented 4 months ago

Please consider and accept the changes

https://github.com/OWASP/Go-SCP/pull/101

dreddsa5dies commented 4 months ago

@PauloASilva hi! https://github.com/OWASP/Go-SCP/pull/101 - changes have been proposed, are there any comments?

PauloASilva commented 4 months ago

@PauloASilva hi! #101 - changes have been proposed, are there any comments?

None other than lack of spare time from my side. Sorry for the delay.

Your changes were released in v2.6.5.

dreddsa5dies commented 4 months ago

You are best, thanks