search

OWASP / Go-SCP

Golang Secure Coding Practices guide
https://owasp.org/www-project-go-secure-coding-practices-guide/
Creative Commons Attribution Share Alike 4.0 International
4.83k stars 369 forks source link

show example of placeholder syntax #20

Closed nicobouliane closed 7 years ago

nicobouliane commented 7 years ago

The example have been taken here: http://go-database-sql.org/prepared.html

their text is licensed under crative common.

PauloASilva commented 7 years ago

Hi @nicobouliane, I think it will be better putting the footnote and your contribution inline with the text: as it is now, makes the footnote bigger than a footnote should be.

Please see the suggested patch: pr-20.txt

Regards, Paulo

PauloASilva commented 7 years ago

Hi @nicobouliane, We're about to release the version v1.1 and we would be glad to add your contribution. Can you please review my previous comment and the attached patch?

Regards, Paulo

PauloASilva commented 7 years ago

This would fix #20

nicobouliane commented 7 years ago

Hi ! I have updated the pull request based on your patch review ! Sorry for the delay, I'm currently on vacation :)

PauloASilva commented 7 years ago

Hi @nicobouliane, Sorry about messing with your vacation time.

Last request: can you please open the Pull Request to our develop branch? We're following Vincent Driessen's A successful Git branching model taking advantage of Gitflow and Git Flow Hooks as explained in How To Contribute section: it is of a great help managing releases, hotfixes, etc. but we should make it clear on README.

Best, Paulo

PauloASilva commented 7 years ago

I will close this: PR#30 did it.