OWASP / Go-SCP

Golang Secure Coding Practices guide
https://owasp.org/www-project-go-secure-coding-practices-guide/
Creative Commons Attribution Share Alike 4.0 International
4.83k stars 369 forks source link

Multiple (mostly crypto) Improvements #31

Closed Jack64 closed 7 years ago

Jack64 commented 7 years ago

Hi guys,

Great job on the SCP šŸ‘ I did find a couple of issues on the crypto side of it, so here's a PR with my suggested changes.

Best regards, JoĆ£o

CHANGELOG: Authentication and password management - Validation and Storage:

Cryptographic Practices:

PRNGs:

PauloASilva commented 7 years ago

Hi @Jack64, first of all, thanks for your contribution.

We're following Vincent Driessen's successful branching model as described on How To Contribute section. Because of that, pull requests should be opened to our develop branch from a (feature) branch on your own fork repository.

Right now our develop branch already has multiple fixes and community contributions ready to be released, what will happened soon.

Can o please submit your changes to our develop branch?

Regards, Paulo A. Silva

Jack64 commented 7 years ago

Yes of course, let me close this and re-PR correctly :)