search

OWASP / MASTG-Hacking-Playground

GNU General Public License v3.0
585 stars 138 forks source link

Added new test for owasp-masvs V5.1 #3

Closed krsoninikhil closed 7 years ago

krsoninikhil commented 7 years ago

Added an activity which renders example.com once with http and once with https as a test case for OWASP-MASVS V5.1

PS: Should the .gitignore file be updated?

krsoninikhil commented 7 years ago

I added a .gitignore in app's root and removed those files from git's index, please have a look.

sushi2k commented 7 years ago

Hi Nikhil, thanks for the first pull request in the Hacking Playground :-)

Can you please do the pull request again and only add the following files:

Android/OMTG-Android-App/app/src/main/java/sg/vp/owasp_mobile/OMTG_Android/MyActivity.java Android/OMTG-Android-App/app/src/main/java/sg/vp/owasp_mobile/OMTG_Android/OMTG_NETW_001_Secure_Channel.java Android/OMTG-Android-App/app/src/main/res/layout/activity_omtgnetw_001securechannel.xml Android/OMTG-Android-App/app/src/main/res/layout/content_my.xml Android/OMTG-Android-App/app/src/main/res/layout/content_omtg__netw_001secure__channel.xml Android/OMTG-Android-App/app/src/main/res/values/strings.xml

Also update your .gitignore to: *.iml .idea/workspace.xml .idea/tasks.xml .idea/gradle.xml .idea/dictionaries .idea/libraries .gradle/ build/

Otherwise too much files are changed when you are doing a pull request. Thanks

krsoninikhil commented 7 years ago

Thank you @sushi2k for reviewing, I'll change it as mentioned.

krsoninikhil commented 7 years ago

Changed the PR accordingly, but shouldn't the files you mentioned for .gitignore be removed from this repo as well?