OWASP / Nettacker

Automated Penetration Testing Framework - Open-Source Vulnerability Scanner - Vulnerability Management
https://owasp.org/www-project-nettacker/
Apache License 2.0
3.05k stars 718 forks source link

[Feature] Added Pagination in webUI #818

Closed Freedisch closed 4 months ago

Freedisch commented 4 months ago

Checklist

Changes proposed in this pull request

This PR fixes issue #805 added pagination to web UI for both Crawler and Results page

https://github.com/OWASP/Nettacker/assets/82499435/5e31924d-266e-45fb-8673-49660cac7914

Your development environment

securestep9 commented 4 months ago

Thank you for your contribution. In our example you only have 5 pages, however have you tested your solution in situations when results contain lots of pages (for example 50 or 500) taking the entire width of the screen? what happens in that case?

Freedisch commented 4 months ago

@securestep9, Depending on the total number of page, but When we have more than 4 pages only 4 buttons will be always displayed and updated. If we are at the 49th element, the numbers will be displayed like the following 47 48 49 50

Screenshot 2024-03-04 at 16 17 11 Screenshot 2024-03-04 at 16 17 03