search

OWASP / O-Saft

O-Saft - OWASP SSL advanced forensic tool
GNU General Public License v2.0
372 stars 97 forks source link

[makefile] add explicit call to interpreters on install target #111

Closed samueloph closed 2 years ago

samueloph commented 5 years ago

I noticed that the build was failing on my machine because the interpreter call was missing on Makefile.

I'm not sure why this was a problem just for me, I'm building it in a clean environment using sbuild and with the following command: make -j8 install DESTDIR=/<<PKGBUILDDIR>>/debian/o-saft AM_UPDATE_INFO_DIR=no "INSTALL=install --strip-program=true"

Thanks

EnDe commented 5 years ago

The Makefile uses direct calls to scripts at various targets/rules. The shell calling these scripts should start the interpreter specified in the hashbang line. It's the responsbility of the calling system. Adding sh/perl at one place (the install target here) would break the general behaviour.

Even I prefer scripts without useless filename extensions (like .sh or .pl), they are used for most scripts to make them work in stupid "so-called" operating systems ;-) May be the calling system needs to be prepared.

If there is a problem in some situations, I'd like to fix them, but it must be done in a general way.

Could it be that the scripts in this target are not found via $PATH? Please post a more detailed (error) message.

Thanks.

EnDe commented 5 years ago

install target now uses a full path for o-saft.pl Does this solve at least half of the problem?

samueloph commented 2 years ago

Thanks for the help, unfortunately I somehow missed your reply and just noticed it now, due to the new release.

I'm no longer calling the install target from the Makefile, but I believe I've done it earlier and it wasn't an issue. In any case, I seemed to be the only one having this issue, so I'm gonna close this PR.