OWASP / O-Saft

O-Saft - OWASP SSL advanced forensic tool
GNU General Public License v2.0
373 stars 86 forks source link

--short leads to error message "Use of uninitialized value $label in concatenation (.) or string at ./o-saft.pl line 3848." #38

Closed xthk closed 9 years ago

xthk commented 9 years ago

The --short option seems to lead to warning messages.

Example:

$ ./o-saft.pl --short +hsts www.twitter.com

Output:

=== reading: ./.o-saft.pl (options done) ===
**WARNING: Can't do DNS reverse lookup: for www.twitter.com: <<gethostbyaddr() failed>>; ignored
**WARNING: no reply: 'Connection reset by peer'
HTTPS STS MaxAge:                   631138519
HTTPS STS sub-domains:
Redirects to same host:                 yes
STS header not for IP:                  yes
HTTP Status code is 301:                yes
HTTP Status code not 30x:               yes
STS and Location header:                no (https://twitter.com/)
Redirects without STS:                  yes
STS and no Refresh header:              yes
STS header:                             yes
STS long max-age:                       no (631138519 = 7304 days)
Use of uninitialized value $label in concatenation (.) or string at ./o-saft.pl line 3848.
:                                       no (> 0)
Use of uninitialized value $label in concatenation (.) or string at ./o-saft.pl line 3848.
:                                       no (> 86400)
Use of uninitialized value $label in concatenation (.) or string at ./o-saft.pl line 3848.
:                                       no (> 2592000)
Use of uninitialized value $label in concatenation (.) or string at ./o-saft.pl line 3848.
:                                       no (> 31536000)
Use of uninitialized value $label in concatenation (.) or string at ./o-saft.pl line 3848.
:                                       yes
STS includeSubdomain:                   no ( )

Without --short no warning regarding uninitialized values is shown.

EnDe commented 9 years ago

Fixed in https://github.com/OWASP/O-Saft/commit/689409689610cc4be9817f1dfc76efacdafd9630

Thanks for reporting