Wrong encoder used for tests in EncoderTest

[renaatdemuynck]

Canonicalization tests 108 through 125 (JavaScript & CSS) fail in EncoderTest because the wrong encoder is used. I verified this by putting a var_dump of the encoder instance in test 108:

  ["_codecs":"DefaultEncoder":private]=>
  array(2) {
    [0]=>
    object(HTMLEntityCodec)#2002 (0) {
    }
    [1]=>
    object(PercentCodec)#1973 (0) {
    }
  }

This clearly shows it uses the wrong codecs. This is because each assertion is being done in a separate test. Before each test setUp() is run which resets the encoder to the one needed for HTML tests.

There are at least four ways to solve this issue:

• Combine all canonicalization test and set the encoder before each set of assertions (HTML, JS, CSS). I prefer this because it is how it's being done in ESAPI's Java couterpart (https://github.com/ESAPI/esapi-java-legacy/blob/master/src/test/java/org/owasp/esapi/reference/EncoderTest.java).
• Define different instances (e.g. $_htmlEncoderInstance) in setUp() (optionally combined with first sulution).
• Put each set of assertions in a different test file with its own setUp(). This will create a lot of extra files.
• Set the encoder in each test. Lots of duplicate code!

I tested the first option and it resolves all failed tests for JavaScript and CSS codecs.