search

OWASP / SecurityShepherd

Web and mobile application security training platform
https://owasp.org/www-project-security-shepherd/
GNU General Public License v3.0
1.35k stars 460 forks source link

get rid of library json-simple (#732) #733

Closed rudosch closed 2 years ago

rudosch commented 2 years ago

issue #732

rudosch commented 2 years ago

I'll have a look on the failed linter check asap

rudosch commented 2 years ago

I will add another commit to restore setting of content type.

rudosch commented 2 years ago

I'm sorry, I can't find the linting error. Do you? Shall I close this PR and start over with a new one, this time based on your recent commits?

ismisepaul commented 2 years ago

This is annoying alright, what I do is run the google-java-formatter tool to automatically do it for me and then push e.g.

1) Download https://github.com/google/google-java-format/releases/tag/v1.15.0 2) Run java -jar google-java-format-1.15.0-all-deps.jar --replace <PATH-TO-PROJECT>/SecurityShepherd//**/*.java

rudosch commented 2 years ago

Thanks for your hint, but I should have been more clear in my previous comment: I already checked my PR commits (i.e. the files changed by those commits) exactly like you said and found no issues! I used parameter -n to let the linter tell me which files will be affected by changes, but there were none. (that's how I was able to fix the linter issues of my very first commit of this PR) So I'll have another look at it tonight.

rudosch commented 2 years ago

I finally found the extra blank line that the linter didn't like ;-)

ismisepaul commented 2 years ago

Thanks @rudosch maybe the linting happens in the pipeline so people don't have to go through this headache...

I'm surprised the --replace flag when running google-java-format didn't work though (it's saved me a few headaches in the past)

That's 4 CVEs taken care of this week 🎉