search

OWASP / cornucopia

The source files and tools needed to build the OWASP Cornucopia decks in various languages
https://cornucopia.owasp.org
Other
46 stars 22 forks source link

Missing eps graphics for the back of the cards. #288

Closed sydseter closed 9 months ago

sydseter commented 10 months ago

Describe the bug I started reviewing the idml files in Indesign and noticed that there is a hardcoded link to a eps file which provides the background for the card. I can't find it in the repository which lead me to believe that it is missing and hasn't been provided in the original template.

We should find a way to include the graphics in a way so that it is either embedded or properly linked to during the idml conversion. please have a look at the screenshot from Indesign with the error and the pdf that I printed after opening the file in Indesign.

To Reproduce Steps to reproduce the behavior:

  1. Open any of the idml files in Indesign and try to print the deck
  2. Choose Windows -> Links to get the list of errors

Expected behavior The graphics should not be missing if they are needed in order to print the cards.

Screenshots backofcards_eps_missing

Error: Name cornocopia back of card elements.eps Format EPS Page 1 Status Missing Size 2.8 MB (2896558 bytes) Title Print Creator Adobe Illustrator CS6 (Macintosh) Place Date Monday, July 11, 2016 1:38 PM Layer Default Path \Users\agb\Downloads\cornucopia-ecom-1v20en-owasp\Cards\Links\cornocopia back of card elements.eps Creation Date Thursday, October 10, 2013 5:22 PM Scale 100%

Desktop (please complete the following information):

Additional context Pdf output from Indesign: cornucopia.pdf

rewtd commented 10 months ago

Let's catch up on this? Are you on Slack?

sydseter commented 10 months ago

Just ping me when you have the time.

sydseter commented 9 months ago

@rewtd I am able to embed the eps file into the idml, but it will increase the filesize with 4MB which is quite a lot. I am thinking we could remedy that by using https://git-lfs.com/ I think we will anyway need to find a solution like this since we have opted for storing the output files. Over time, it will become impossible to clone the repository due to the size of the index that need to keep track of changes between the each version of binary files. This will solve that.

Please tell me if you have any concerns about this.