Vagrant deployment according to the documentation was not working as expected. The reason being sed -e pattern inside deployment script was not correct, therefore not performing the substitution of that string.
As a result the docker containers would spin with config 127.0.0.1:8888:80. This means the container is only exposed on the 127.0.0.1 interface and would not be accessible outside the VM box.
This change fixes #202 by modifying the /deploy/vagrant/provision.sh to use the correct sed -e replacement pattern to match the pattern on docker-compose.yml file.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested the service locally.
Documentation
Did not need to update documentation.
Checklist:
[X] My changes generate no new warnings
[X] I have added tests that prove my fix is effective or that my feature works
[X] Any dependent changes have been merged
[X] I have documented any changes if required in the docs.
Description
Vagrant deployment according to the documentation was not working as expected. The reason being sed -e pattern inside deployment script was not correct, therefore not performing the substitution of that string.
As a result the docker containers would spin with config 127.0.0.1:8888:80. This means the container is only exposed on the 127.0.0.1 interface and would not be accessible outside the VM box.
This change fixes #202 by modifying the
/deploy/vagrant/provision.shto use the correct sed -e replacement pattern to match the pattern ondocker-compose.ymlfile.Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested the service locally.
Documentation
Did not need to update documentation.
Checklist: