Open PastNullInfinity opened 5 years ago
Hey, sorry for the delay. Yes, that sounds like a great addition both to the slack reporter and as a standalone reporter.
The only concern is the image size - but unless wkhtmltopdf
is a big library, I don't see any issue with it :)
The wkhtmltopdf
binary itself is small, and a couple of dependencies for things like font support are needed. I've not checked the diff, but I think it should not be very large.
One other option would be generating the PDF using something like prawn, although creating a suitable template will be considerably more work, since it cannot use an ERB template as an input (the prawn templating module has been deprecated quite some time ago)
Sounds good! Looking forward to seeing your PR :)
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
I'm currently working on a PDF reporter that uses an ERB template to output an html, and then call
wkhtmltopdf
for rendering the final file. The main reason for me was to create a nice output for the report to send via the Slack reporter, in case the amount of issues found was large.The changes should be relatively easy to merge, the only new dependency would be
wkhtmltopdf
.I'm open to discussion if anyone wants to propose a better solution