OWASP / java-html-sanitizer

Takes third-party HTML and produces HTML that is safe to embed in your web application. Fast and easy to configure.
Other
843 stars 213 forks source link

hsl() and hsla() preserved #216

Closed aakritisi closed 3 years ago

aakritisi commented 3 years ago

Fixed #212

mikesamuel commented 3 years ago

Thanks.

jmanico commented 3 years ago

Working on this library requires a great deal of sophistication. Can you start by reading the code and understand what the sanitizer is and how it works internally?

Then you can take on some issues, but talk to use about your approach before you dive in.

Also, if the code is overly complex, please review our wiki and OWASP pages and look for typos or inconsistencies.

Is that a good start?

Aloha. Jim

On 12/9/20 6:03 PM, aakritisi wrote:

Hey, I am looking to contribute more on your project. Could you suggest some issues that need to be fixed? Something that doesn't take a lot of time is preferred.

Thanks, Aakriti Singh

On Wed, Dec 9, 2020, 10:09 Mike Samuel notifications@github.com wrote:

Merged #216 https://github.com/OWASP/java-html-sanitizer/pull/216 into main.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub

https://github.com/OWASP/java-html-sanitizer/pull/216#event-4090424412, or unsubscribe

https://github.com/notifications/unsubscribe-auth/AGAR6YJYPLFAEKBYRZWP77LST6HKJANCNFSM4UTQMTLA .

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OWASP/java-html-sanitizer/pull/216#issuecomment-742224289, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEBYCM2WED4YGRBAAASW3LSUBB73ANCNFSM4UTQMTLA.

-- Jim Manico Manicode Security https://www.manicode.com

mikesamuel commented 3 years ago

On Wed, Dec 9, 2020 at 11:03 PM aakritisi notifications@github.com wrote:

Hey, I am looking to contribute more on your project. Could you suggest some issues that need to be fixed? Something that doesn't take a lot of time is preferred.

Thanks, Aakriti Singh

Sorry, I haven't made the project very easy for new contributors.

If you're looking for something quick, something with a low learning curve is probably best. What do you see as your strengths?

On Wed, Dec 9, 2020, 10:09 Mike Samuel notifications@github.com wrote:

Merged #216 https://github.com/OWASP/java-html-sanitizer/pull/216 into main.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <https://github.com/OWASP/java-html-sanitizer/pull/216#event-4090424412 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AGAR6YJYPLFAEKBYRZWP77LST6HKJANCNFSM4UTQMTLA

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/OWASP/java-html-sanitizer/pull/216#issuecomment-742224289, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAC2B5UOSQBA3JHKV3PRRJTSUBB7ZANCNFSM4UTQMTLA .