Proposed fix for issue #223: forbidden character references in sanitized html

OWASP / java-html-sanitizer

Takes third-party HTML and produces HTML that is safe to embed in your web application. Fast and easy to configure.

Other

843 stars 213 forks source link

Proposed fix for issue #223: forbidden character references in sanitized html #225

Open simon-greatrix opened 3 years ago

mikesamuel commented 3 years ago

I'll look at this in more detail soon. Thanks so much.

simon-greatrix commented 3 years ago

When you asked I was like "I would NEVER submit a merge request with failing test!". Then I looked at my IDE and saw that it said "No tests found", because it has forgotten how JUnit 4 works apparently. So, I'll have to change my claim to "I would never KNOWINGLY submit a merge request with failing tests!"

mikesamuel commented 3 years ago

Heh. Yeah, the codebase has some Java5/6 compatibility baggage.

simon-greatrix commented 3 years ago

Looks OK now - hope those were the correct changes.