OWASP / java-html-sanitizer

Takes third-party HTML and produces HTML that is safe to embed in your web application. Fast and easy to configure.
Other
833 stars 210 forks source link

Update the maven-compiler-plugin to make the --release check work #304

Closed csware closed 5 months ago

csware commented 5 months ago

For the compiler --release check to work, we need a more recent maven-compiler-plugin version (at least 3.6).

relates to issue #301

csware commented 5 months ago

ATM JDK10 is required.

I already have a branch that unbreaks JDK9 and unbreaks JDK8, cf. https://github.com/OWASP/java-html-sanitizer/issues/301#issuecomment-1919244241 and https://github.com/OWASP/java-html-sanitizer/issues/301#issuecomment-1919825639

I can open a PR as soon as PR #302 and PR #313 have been decided (becasue it will conflict with these changes)

csware commented 5 months ago

Maybe we should raise to JDK10 in pom.xml until we have fixes for JDK9...

mikesamuel commented 5 months ago

Ugh. JDK 9 is the new JDK 6.

csware commented 5 months ago

Closed in favor of PR #321