OWASP_MAS_Checklist issue

[SenninSage333]

Hey,

Do you plan to release newer version of OWASP MAS Checklist? I am asking because I have a strange issue. In the current version when I select an answer in the first point for MASVS-STORAGE-1, the color is generated few positions above the row as presented in below screen. Does someone have similar issue?

[bl13pbl03p]

I have the same issue within every tab in the excel file. I repaired the document, but I have no idea where to do a pull request for a new version 😂

[cpholguera]

The excel file is 100 % automatically generated. Here are the relevant scripts

https://github.com/OWASP/owasp-mastg/blob/master/tools/scripts/yaml_to_excel.py

https://github.com/OWASP/owasp-mastg/blob/master/tools/scripts/excel_styles_and_validation.py

You can open a pull request by following these instructions: https://mas.owasp.org/contributing/3_PRs_and_Reviews/

[cpholguera]

@bl13pbl03p would you like me to assign the issue to you?

[cpholguera]

I've assigned to you @bl13pbl03p based on your other message. Thanks for helping out!

[bl13pbl03p]

@cpholguera I will do my best to fix it, but no guarantees can be given 😅. To confirm, all the rows that do not contain a L1, L2 or R value should not have a status column right? For example:

[cpholguera]

Exactly, only the "Status" column should have that. The others are reserved for the levels. No worries if you can't make it in the end, thanks for trying it out!

[cpholguera]

@SenninSage333, @bl13pbl03p, thank you very much for your help. I've fixed the rest of the issues mentioned and now the sheet cell validation should be working fine. Please take a look by downloading it here: https://mas.owasp.org/MAS_checklist/

[bl13pbl03p]

@cpholguera Don't thank us yet, it seems a new bug has been born :(

[cpholguera]

Thank you@bl13pbl03p, I tried on Google Sheets and Apple Numbers and I can't reproduce the issue, I don't have Excel unfortunately. Could you provide more details on how you got that to show?

[bl13pbl03p]

@cpholguera

1. Open the document in Excel via onedrive or via the Excel client application
2. Change status of initial column
3. Coloured column appears two rows above (I11)

Maybe the issue can be fixed by adjusting the status_cells value again (change value from I11 to I13), I will make a pull request

[cpholguera]

Interesting 🤔.. However, I11 must be included, if not we won't be able to mark the MASVS control as Pass/Fail.

[bl13pbl03p]

Hmm, the following shows up in Excel. Color and aligning is only applied to the second row above the column itself.

[cpholguera]

@sushi2k I won't be able to take a look at this in the upcoming weeks. If you have some time and access to excel, would you mind taking a look at this issue and support @bl13pbl03p? Thanks in advance!