search

OWASP / phpsec

OWASP PHP Security Project - THIS PROJECT IS INACTIVE AND MAY CONTAIN SECURITY FLAWS
197 stars 103 forks source link

Last login #100

Closed mebjas closed 10 years ago

mebjas commented 10 years ago

Last login feature implementation

mebjas commented 10 years ago

@abhshkdz review the code, and if we need to implement the last_login feature, I'll directly commit to master!

mebjas commented 10 years ago

done

MysterAitch commented 10 years ago

Cheers mebjas! I'm not at a computer for the near future so thank you for supplying the edit!

As a comment to the whole file, I notice a lot of function names of the format "getXDate".

The functions appear to return a timestamp, not a date. At the very least it is date+time, not just the date. I am a massive supporter of explicit naming and having nil surprises as per "clean code".

I suggest renaming them to be of the format "getXTimestamp" - starting with "getLastLoginTimestamp".

What are your thoughts on this?

mebjas commented 10 years ago

You are correct here, I guess @abhshkdz would be the best candidate here for this!