search

OWASP / phpsec

OWASP PHP Security Project - THIS PROJECT IS INACTIVE AND MAY CONTAIN SECURITY FLAWS
197 stars 103 forks source link

Coding Convention contradicts itself. #104

Closed hakre closed 9 years ago

hakre commented 9 years ago

(All from here: https://github.com/OWASP/phpsec/wiki/Coding-Convention)

PSR-0 with "Class names are CamelCase" contradict to "All file names are lowercase".

You can't follow PSR-0 with exceptions. That makes no sense. You either follow PSR-0 or you roll your own (and PSR-0 is really easy to follow, I can't see why you want to make here exceptions).

vanderaj commented 9 years ago

If you have a class called Members, it will be contained in a file called "members.php". I don't see the issue? This makes the resulting files safe for both case sensitive (Unix) and case insensitive (MacOS X and Windows) extraction and use.

thanks Andrew

hakre commented 9 years ago 
class CamelCase {}

and then the filename

/path/to/src/root/camelcase.php

doesn't work with PSR-0. PSR-0 requires instead:

/path/to/src/root/CamelCase.php
hakre commented 9 years ago

Anyway, I don't see this will get any traction and I already lost my interest. So OK to close for me.