search

OWASP / phpsec

OWASP PHP Security Project - THIS PROJECT IS INACTIVE AND MAY CONTAIN SECURITY FLAWS
197 stars 103 forks source link

Careful with >= #105

Closed philsturgeon closed 8 years ago

philsturgeon commented 9 years ago

The trouble with using >= like that is two-fold.

  1. According to SemVer, 0.7.0 could have breaking changes, which can cause trouble
  2. It will include v1.0, which could be very different

I stick to 0.x.* until 1.0 is out, then switch to ~1.0.

Also ya'll had some messy tab/space combination.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-4.02%) when pulling 2b53a701de5c2c6dab24d830bdbd6bfafd858dc4 on philsturgeon:patch-1 into 8f403e4317edc8e75bec35710127494415329d78 on OWASP:master.

coveralls commented 9 years ago

Coverage Status

Coverage decreased (-4.02%) when pulling 2b53a701de5c2c6dab24d830bdbd6bfafd858dc4 on philsturgeon:patch-1 into 8f403e4317edc8e75bec35710127494415329d78 on OWASP:master.

philsturgeon commented 9 years ago

So this looks like you lot are having a pretty bad time with the test suite and it looks like none of it is anything to do with this PR.