OWASP / phpsec

OWASP PHP Security Project - THIS PROJECT IS INACTIVE AND MAY CONTAIN SECURITY FLAWS
197 stars 103 forks source link

[SECURITY] phpsec/user.php - Timing attack on hash comparison #117

Open AndrewCarterUK opened 8 years ago

AndrewCarterUK commented 8 years ago

Note: I have been asked to log all the security issues that I have found by an OWASP contributor to support the decision to abandon this project. My personal opinion is that all of the code in this repository is beyond repair and that it is not wise to attempt to fix it.

hash_equals should be used to compare hashes to prevent a timing attack.

https://github.com/OWASP/phpsec/blob/1999edc10a3b755ff2b17bb78376bd53dd40d192/libs/auth/user.php#L88