search

OWASP / phpsec

OWASP PHP Security Project - THIS PROJECT IS INACTIVE AND MAY CONTAIN SECURITY FLAWS
197 stars 103 forks source link

HTTP Downloader #15

Closed abiusx closed 11 years ago

abiusx commented 11 years ago
  1. I think its best to move this to http folder, since we're having libs for HTTP Request and HTTP Response.
  2. Its better to change MIME function to use an array. It would be much faster than a lot of ifs. Extension in key, MIME type in value.
  3. IsModifiedSince should be protected.
  4. Same goes for calculate... , also remove underlines from this. http can be lowercase.
  5. readFromFile doesnt have a good name. Its not what it does. Also shouldnt be public
  6. A large portion of the code is duplicated, merge it.
  7. I don't know if Feed is also a good name. If you come up with something smarter use that. If you make everything else protected, anything public is a good remaining name :D
rash805115 commented 11 years ago

done.