search

OWASP / phpsec

OWASP PHP Security Project - THIS PROJECT IS INACTIVE AND MAY CONTAIN SECURITY FLAWS
197 stars 103 forks source link

Code style #20

Closed MysterAitch closed 11 years ago

MysterAitch commented 11 years ago

A few times code style has been mentioned, but I am not sure what the appropriate code style is. Is there a preferred guide located on t'interwebs, perchance?

I have just created a new wiki page containing a few notes with the bits and pieces I have picked up so far - it is very much incomplete and mostly for personal use / reference, but I believe it would be beneficial to add to it every once in a while where decisions are made and/or questions are asked.

abiusx commented 11 years ago

There was already a wiki page for that :D

Notice: This message is digitally signed, its source and integrity are verifiable. If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Tir 16, 1392, at 4:44 PM, howelrtc notifications@github.com wrote:

A few times code style has been mentioned, but I am not sure what the appropriate code style is. Is there a preferred guide located on t'interwebs, perchance?

I have just created a new wiki page containing a few notes with the bits and pieces I have picked up so far - it is very much incomplete and mostly for personal use / reference, but I believe it would be beneficial to add to it every once in a while where decisions are made and/or questions are asked.

https://github.com/OWASP/phpsec/wiki/Coding-Style

— Reply to this email directly or view it on GitHub.

abhshkdz commented 11 years ago

Exactly! https://github.com/OWASP/phpsec/wiki/Coding-Convention

abiusx commented 11 years ago

You can put a more detailed version in your page, I didn't want to make it detailed, cuz then nobody would read and absorb all of it.

Stuff like whitespaces, and indents, and blank lines doesnt matter much, because all IDEs can automatically change the whole package to a convention, but namings and access specifiers are, cuz no automated tool can fix them. -Abbas

Notice: This message is digitally signed, its source and integrity are verifiable. If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Tir 16, 1392, at 4:46 PM, Abhishek Das notifications@github.com wrote:

Exactly! https://github.com/OWASP/phpsec/wiki/Coding-Convention

— Reply to this email directly or view it on GitHub.

MysterAitch commented 11 years ago

Awww shoot, don't I feel like an idiot now >.<`

Sorry all!

abiusx commented 11 years ago

well you had to send an introduction email to mailing list, and you would see that there. bump -A

Notice: This message is digitally signed, its source and integrity are verifiable. If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Tir 16, 1392, at 4:53 PM, howelrtc notifications@github.com wrote:

Awww shoot, don't I feel like an idiot now >.<`

Sorry all!

— Reply to this email directly or view it on GitHub.

MysterAitch commented 11 years ago

I just deleted the extra page ;)