search

OWASP / phpsec

OWASP PHP Security Project - THIS PROJECT IS INACTIVE AND MAY CONTAIN SECURITY FLAWS
197 stars 103 forks source link

One line if statements #25

Closed vanderaj closed 11 years ago

vanderaj commented 11 years ago

Please always use braces, even if it's only one line. It's also in the PSR that this project uses.

Wrong:

if ( $foo )
    blah();

Right:

if ( $foo ) {
    blah();
}

The wrong way is a constant source of maintenance bugs, so let's just be strict about it.

abiusx commented 11 years ago

We will be using a round of automatic syntax change using tools at the end, thats why not much pressure is put on the team for now. Check the style convention wiki page. -A

Notice: This message is digitally signed, its source and integrity are verifiable. If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Tir 26, 1392, at 3:32 PM, vanderaj notifications@github.com wrote:

Please always use braces, even if it's only one line. It's also in the PSR that this project uses.

Wrong:

if ( $foo ) blah(); Right:

if ( $foo ) { blah(); } The wrong way is a constant source of maintenance bugs, so let's just be strict about it.

— Reply to this email directly or view it on GitHub.

rash805115 commented 11 years ago

So like abbas pointed out, I am leaving this for now....we will apply a general guideline to the whole package in the end....