search

OWASP / phpsec

OWASP PHP Security Project - THIS PROJECT IS INACTIVE AND MAY CONTAIN SECURITY FLAWS
197 stars 103 forks source link

The "tabs" vs. "spaces" issue #59

Closed SvenRtbg closed 10 years ago

SvenRtbg commented 11 years ago

I'd really like to see this project implement a no-tabulator policy for the source code. It's the only true deviation from all the PSR coding standards, and it is painful.

Can we simply revert this decision without much ado?

abiusx commented 11 years ago

We certainly can, but for the development phase we're leaving it be. We will use automated tools to convert everything for a release.

Notice: This message is digitally signed, its source and integrity are verifiable. If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Mordad 22, 1392, at 2:46 AM, SvenRtbg notifications@github.com wrote:

I'd really like to see this project implement a no-tabulator policy for the source code. It's the only true deviation from all the PSR coding standards, and it is painful.

Can we simply revert this decision without much ado?

— Reply to this email directly or view it on GitHub.

SvenRtbg commented 11 years ago

I have an automated tool available right now, and will be adding coding style checks to the Travis build to help during the development phase. Everyone will be annoyed by a huge, all-affecting nothing-changing style change commit, but the sooner, the better. If we enforce the style from the start, everyone will get accustomed to it soon.

abiusx commented 11 years ago

some people are annoyed by spaces instead of tabs, the same way you're. its just about productivity.

Notice: This message is digitally signed, its source and integrity are verifiable. If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Mordad 22, 1392, at 3:27 AM, SvenRtbg notifications@github.com wrote:

I have an automated tool available right now, and will be adding coding style checks to the Travis build to help during the development phase. Everyone will be annoyed by a huge, all-affecting nothing-changing style change commit, but the sooner, the better. If we enforce the style from the start, everyone will get accustomed to it soon.

— Reply to this email directly or view it on GitHub.

SvenRtbg commented 11 years ago

Currently I'm more annoyed by commits that have 8 spaces instead of 1 tab and mess up the formatting... :)

abiusx commented 11 years ago

you mean commit comments, or php code files?

Notice: This message is digitally signed, its source and integrity are verifiable. If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Mordad 22, 1392, at 3:32 AM, SvenRtbg notifications@github.com wrote:

Currently I'm more annoyed by commits that have 8 spaces instead of 1 tab and mess up the formatting... :)

— Reply to this email directly or view it on GitHub.

SvenRtbg commented 11 years ago

Code files.

abiusx commented 11 years ago

its odd, i havent faced any. could you point to one?

Notice: This message is digitally signed, its source and integrity are verifiable. If you mail client does not support S/MIME verification, it will display a file (smime.p7s), which includes the X.509 certificate and the signature body. Read more at Certified E-Mail with Comodo and Thunderbird in AbiusX.com

On Mordad 22, 1392, at 3:34 AM, SvenRtbg notifications@github.com wrote:

Code files.

— Reply to this email directly or view it on GitHub.

SvenRtbg commented 11 years ago

This for example: f0d6cc3e175eea232444e596c672f4a743102ea4

rash805115 commented 11 years ago

But in this file, I have used tabs....plus in the codes, the spacing is right....maybe it is just looking like this....in the code, all is ok....

On Tue, Aug 13, 2013 at 4:38 AM, SvenRtbg notifications@github.com wrote:

This for example: f0d6cc3https://github.com/OWASP/phpsec/commit/f0d6cc3e175eea232444e596c672f4a743102ea4

— Reply to this email directly or view it on GitHubhttps://github.com/OWASP/phpsec/issues/59#issuecomment-22532754 .

Regards, Rahul Chaudhary Ph - 412-519-9634