search

OWASP / pytm

A Pythonic framework for threat modeling
Other
907 stars 169 forks source link

Added `prerequisites` and `likelihood` to Threat #241

Closed raphaelahrens closed 5 months ago

raphaelahrens commented 5 months ago

In threats.json the two properties ("prerequisites", "Likelihood Of Attack") are defined, but are not used in the rest of pytm.

This commit adds the two properties to the Threat class, so they can be used by other parts of pytm.

For me this was relevant, since I started to experiment with a different format for threats mentioned in #237 . And after exporting threat.json to a markdown format and back into threat.json these two fields where missing.

izar commented 5 months ago

thanks!

raphaelahrens commented 5 months ago

One question do you want to use the values somewhere? They could be used in the findings, but I still wonder why they where not in the Threat class and if there was a reason.