search

OWASP / railsgoat

A vulnerable version of Rails that follows the OWASP Top 10
railsgoat.cktricky.com
MIT License
867 stars 667 forks source link

Update README.md #338

Closed hardlyhuman closed 6 years ago

jasnow commented 6 years ago

Here is some information on why we have "rails" instead of "rake" in the README file for our Rails 5 version.

hardlyhuman commented 6 years ago

Thanks for the information. I hope the latest update would make more sense. If not required, we can close this PR

cktricky commented 6 years ago

@SriHarshaGajavalli Out of curiosity, do you know why are the errors occurring when using rails versus rake?

jmmastey commented 6 years ago

Maybe we could update the docs to say something like:

Rails 5+:
bundle exec rails db:migrate

Rails < 5:
bundle exec rake db:migrate
jasnow commented 6 years ago

@jmmastey - more than 1 place to update in README file

cktricky commented 6 years ago

Hey @jmmastey in your PR you'd made this modification (switch from rake to rails) and I actually still think its a good idea to keep it as-is. Easier to maintain and if a user has an error, they can ask questions which will get us involved to help them out (get them on the right version). Also, on the older branches, we give the correct instruction for those branches.

Unless anyone strongly disagrees, I think we're okay to close this one out 👍