search

OWASP / railsgoat

A vulnerable version of Rails that follows the OWASP Top 10
railsgoat.cktricky.com
MIT License
866 stars 667 forks source link

Added Openshift Support #376

Closed relotnek closed 4 years ago

relotnek commented 4 years ago

Added environments, config files, and README instructions for an openshift deployment with postgresql. This modifies folder ownership in the Dockerfile and adds the pg gem as well.

cktricky commented 4 years ago

Hey @relotnek 👋 - firstly, thanks for doing this! Secondly, would it be possible to move the openshift documentation into docs/openshift.md and then link to it from within the README.md? Just because it's pretty lengthy. I'll probably do the same for anything docker related or lengthy in general after you've created that docs folder and openshift.md file. If you're "meh" on doing that let me know and I'll merge this and then make that change myself (you've already done a bit of work here ❤️).

relotnek commented 4 years ago

Absolutely no problem, I'll move the docs

cktricky commented 4 years ago

Thanks @relotnek !!!

relotnek commented 4 years ago

No problem, just made the update. I already had an openshift group in there, just forgot to remove the main dependency

relotnek commented 4 years ago

So these latest changes fix the issue and move what needs to be moved, but I've had to update the dockerfile to bundle with the openshift group. I'm open to suggestions, but the only option I can see is that we host the prebuilt openshift image or ensure that both the Docker and Openshift build use pg

relotnek commented 4 years ago

I think I figured out a way to do this with the openshift Docker strategy - it should allow a deploy from the openshift-configs directory while preserving a database agnostic standard Dockerfile

cktricky commented 4 years ago

Thank you so much for bearing with all the changes (and my forgetfulness 😂 ). You rock @relotnek 🍻