search

OWASP / threat-dragon

An open source threat modeling tool from OWASP
https://owasp.org/www-project-threat-dragon/
Apache License 2.0
902 stars 244 forks source link

Desktop: Landscape Diagram Export option #221

Closed nickrmc83 closed 1 year ago

nickrmc83 commented 4 years ago

Is your feature request related to a problem? Please describe.

👋 I've been using this great tool for a little while but we keep hitting a minor niggle which we'd love to see improved. When exporting reports using the Mac desktop app much of the time the diagrams include scrolls bars. It would be great to either be able to fit-to-width and/or output diagrams as landscape so that the scrollbars can be removed and so more space is available.

Describe the solution you'd like

The option to export diagrams in landscape to better support larger and more complex systems.

Describe alternatives you've considered

None

Additional context

jgadsden commented 4 years ago

Hello @nickrmc83 - I am glad you like Threat Dragon, and this is a good suggestion, thankyou. It would be a good enhancement to have a landscape option ... it maybe could be a tick box in app/threatmodels/desktopreport.html with this option being applied in app/threatmodels/desktopreport.js.

Yogendra0Sharma commented 4 years ago

@jgadsden Can you please assign it to me.

jgadsden commented 4 years ago

@Yogendra0Sharma - all yours! thanks for taking this on

jgadsden commented 4 years ago

Hello @Yogendra0Sharma , we may be releasing Threat Dragon at the end of this week. Do you want to get this fix in to this version 1.3.1 release?

jgadsden commented 4 years ago

Hello @Yogendra0Sharma , we are very close to the release, do you mind if someone else works on this issue so that it can be released?

Yogendra0Sharma commented 4 years ago

Hello @Yogendra0Sharma , we are very close to the release, do you mind if someone else works on this issue so that it can be released?

Sure.

jgadsden commented 4 years ago

After some working through the code, this feature requires a change to be made to the threat dragon core file : https://github.com/OWASP/threat-dragon-core/blob/main/src/threatmodels/threatmodelreport.html

and so we can put this feature back to version 1.4. This gives much more time for you @Yogendra0Sharma ? I now realise that this is not a good first issue - so I have removed the label - and if you want help on this one I can give it.

jgadsden commented 3 years ago

Raised an issue to support this in the core repo: https://github.com/OWASP/threat-dragon-core/issues/70

jgadsden commented 3 years ago

Transferred to threat dragon repo

jauharbal commented 2 years ago

Is Export option implemented on the Desktop version? I have been looking for the same, but I couldn't find it.

jgadsden commented 2 years ago

Is Export option implemented on the Desktop version? I have been looking for the same, but I couldn't find it.

Hello @jauharbal , not yet but if you are interested in coding it that would be great Cheers, Jon

jgadsden commented 1 year ago

Issue #127 duplicates this

jgadsden commented 1 year ago

This has been addressed in version 2.0.2 - the diagrams in the reports are scaled to fit and no longer have scroll bars