search

OWASP / threat-dragon

An open source threat modeling tool from OWASP
https://owasp.org/www-project-threat-dragon/
Apache License 2.0
940 stars 253 forks source link

I18N: add German translation #524

Closed jgadsden closed 1 year ago

jgadsden commented 2 years ago

Describe what problem your feature request solves It would be good to have the German translation for Threat Dragon

Describe the solution you'd like Modify translation file

Additional context

jgadsden commented 2 years ago

All yours if you would like to take this on @sparticvs

sparticvs commented 2 years ago

@jgadsden I'm looking into this further, I think there is an assumption of English grammar in the structuring here - I'm looking into this further, but we may need to make some other adjustments to get a coherent German translation. I'll likely leave parts of this in English to purely support not needing any UI changes at the moment. I'm not 100% certain at the moment, so I'm still investigating this.

jgadsden commented 2 years ago

I am sure you are right; we can shuffle the text strings around, even combine and split them, if necessary. Feel free to do this if you need to and we can fix up the other translations to suit

professorabhay commented 1 year ago

Hey @jgadsden, Can I resolve this issue and merge PR after creating and close this also??👨🏻‍💻 Please explain it little more to me!!

jgadsden commented 1 year ago

Hello @professorabhay , how good is your German language? At present this is assigned to @sparticvs , so I would like to leave it with him

professorabhay commented 1 year ago

🥲 Not so good Just basic but I can do it correctly 🤠

sparticvs commented 1 year ago

@professorabhay - Mochtest du die Veränderungen überprüfen?

@jgadsden - I've been working on this in my spare time, which has me slowed down with a new puppy and toddler in the mix. I've been also making sure that the wording is aligned with the threat modeling papers that have been published by students from German universities.

professorabhay commented 1 year ago

@sparticvs Ya sicher !!

jgadsden commented 1 year ago

@Zmiler you may want to work with @sparticvs on this tranlsation?

Zmiler commented 1 year ago

I would gladly help with translation. I am a native german speaker

sparticvs commented 1 year ago

I'll push up what I have completed ASAP if you want it.

@jgadsden how do you want the tracking done where the grammar doesn't work with the templating?

jgadsden commented 1 year ago

ah, can you give an example @sparticvs ? I am not sure what you mean

Zmiler commented 1 year ago

@jgadsden I translated most of it. I did not see any weird text wrapping yet. I will translate the remaining bits tomorrow and check all areas of the application

sparticvs commented 1 year ago

@jgadsden my concern was with the break up of "select", "from", etc. Looking at @Zmiler's translation, there probably isn't an issue after all.