OWASP / threat-dragon

An open source threat modeling tool from OWASP
https://owasp.org/www-project-threat-dragon/
Apache License 2.0
902 stars 244 forks source link

I18N: update ES translation file #529

Closed jgadsden closed 1 year ago

jgadsden commented 2 years ago

Describe what problem your feature request solves As Threat Dragon begins to approach the release of version 2.0, it would be good to update the Spanish translation

Describe the solution you'd like Modify translation file

Additional context

jgadsden commented 2 years ago

I added some translations strings into the i18n file, but my Spanish is not as good as I thought it was, so it is incomplete

professorabhay commented 1 year ago

Hey @jgadsden, Can I resolve this issue and merge PR after creating and close this also??👨🏻‍💻

jgadsden commented 1 year ago

Hello @professorabhay , yes please go ahead and take on the Spanish translation if you like. Thanks again!

professorabhay commented 1 year ago

I'll do this asap!!🙂

jgadsden commented 1 year ago

Hello @professorabhay , how good is your Spanish language?

professorabhay commented 1 year ago

Hola 👋 @jgadsden, I can't speak fluently but I can survive in Spanish country. Or, In other way I can translate this 99% correctly.

jgadsden commented 1 year ago

Hello @professorabhay , really we need a fluent Spanish speaker to do this translation. I myself can speak Spanish fairly well, but I would not attempt translation of technical terms - it is not straight forward at all.

I hope you do not mind but it would be better to get a fluent Spanish speaker to do this translation

professorabhay commented 1 year ago

@jgadsden But I think that, we don't need a speaker for this. We can use another method to resolve this. No need of a Spanish speaker, we can do this by google translator for this work also. We can update values line by line after translating to Spanish. And I think that there is no need to tell, How good and efficient google translator is!!

something like shown in this reference image ==>> oswap new

jgadsden commented 1 year ago

The problem with Google translate is that the translation can miss the subtleties of the language. The Spanish example given above was provided by a native Spanish speaker, but the Google version would be: "Esta es la versión 2.0 de OWASP Threat Dragon y aún está en desarrollo. ¡No use esto para editar modelos existentes, ya que esta versión podría romperlos!" which loses some of the technical meaning. If we translate the original Spanish version, or the Google version, into English using Google translate we get the same wording, and so missing some of the subtleties of Spanish.

Having said that, there is a typo and the 'do' should be 'de'

professorabhay commented 1 year ago

Ok !! No problem

jgadsden commented 1 year ago

@yaso and @GigliolaCordova is it OK to assign this to you? You provided the original translation file

jgadsden commented 1 year ago

Pull request #606 closes this issue